| |
VK7AX > LINHAM 20.06.08 02:52l 80 Lines 2321 Bytes #999 (0) @ WW
BID : VK7AX-2006SY
Read: GUEST
Subj: Re: [PATCH] ax25.h unsigned long type for ax25 timers
Path: IZ3LSV<IK2XDE<DB0RES<WA7V<VK7AX
Sent: 080620/0056Z @:VK7AX.#ULV.TAS.AUS.OC #:47600 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: Bernard Pidoux <bpidoux(AT)free.fr>
Date: Thu, 19 Jun 2008 18:28:46 +0200
To: David Miller <davem(AT)davemloft.net>
CC: ralf(AT)linux-mips.org, linux-hams(AT)vger.kernel.org,
netdev(AT)vger.kernel.org
David,
Unfortunately I don't quite understand exactly why a structure
in user space cannot be changed.
But this means that I have to make some effort to learn a bit
more about the kernel structure and userspace.
However, thank you for your explanation about how to fix the
discrepancy between both timer structures.
I will try to dig out more information on this subject.
Bernard Pidoux, f6bvp
David Miller a écrit :
> From: Bernard Pidoux <bpidoux(AT)free.fr>
> Date: Tue, 17 Jun 2008 15:04:38 +0200
>
>
>> In linux/include/linux/ax25.h
>> ax25_info_struct timers types remain unsigned
>>
>> struct ax25_info_struct {
>> unsigned int n2, n2count;
>> unsigned int t1, t1timer;
>> unsigned int t2, t2timer;
>> unsigned int t3, t3timer;
>> unsigned int idle, idletimer;
>> .....
>> };
>>
>> while in linux/include/net/ax25.h timers are unsigned long
>> according to kernel 2.6 timers.
>>
>> typedef struct ax25_cb {
>> .....
>> struct timer_list t1timer, t2timer, t3timer, idletimer;
>> unsigned long t1, t2, t3, idle, rtt;
>> ....
>>
>> Although ax25_info_struct is not much used it is refered at least
>> into libax25 and xfbb BBS application program.
>>
>> It seems thus reasonable to make the change.
>>
>> Signed-off-by: Bernard Pidoux <f6bvp(AT)amsat.org>
>>
>
> Unfortunately this datastructure is exported to userspace,
> and therefore we cannot change the structure layout without
> breaking userspace.
>
> We cannot, as a result, make this change.
>
> The only way to fix this is to make a new fixed structure, and add new
> ax25 calls that accept this new structure.
>
>
>
--
******************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN EFFORT TO
PROMOTE FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING
SYSTEMS AND PACKET RADIO
Courtesy Tony VK7AX VK7AX(AT)VK7AX.#ULV.TAS.AUS.OC
******************************************************************
Read previous mail | Read next mail
| |
