| |
VK7AX > LINHAM 20.06.08 02:52l 80 Lines 2335 Bytes #999 (0) @ WW
BID : VK7AX-2006SK
Read: GUEST
Subj: Re: [PATCH] ax25.h unsigned long type for ax25 timers
Path: IZ3LSV<IK2XDE<DB0RES<DB0GOS<ON0AR<ZL2BAU<VK7AX
Sent: 080620/0056Z @:VK7AX.#ULV.TAS.AUS.OC #:47601 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: Al <awvger(AT)sunnyside.com>
Date: Thu, 19 Jun 2008 12:38:10 -0700
To: linux-hams(AT)vger.kernel.org
David
My impression was that the proposed change did NOT change binary
interfaces to the kernel, but correctly labeled fields for the
first time specifically as "long" instead of the fuzzy definition
as "int".
While it's true that a non-386 system where "int" is not a "long"
would be adversely affected, there appear not to be any of those
(rare) systems running this software, so the point seems
entirely moot.
The proposed change improves strict type checking and makes a
cleaner definition.
I say let it in.
Al
David Miller wrote:
> From: Bernard Pidoux <bpidoux(AT)free.fr>
> Date: Tue, 17 Jun 2008 15:04:38 +0200
>
>
>> In linux/include/linux/ax25.h
>> ax25_info_struct timers types remain unsigned
>>
>> struct ax25_info_struct {
>> unsigned int n2, n2count;
>> unsigned int t1, t1timer;
>> unsigned int t2, t2timer;
>> unsigned int t3, t3timer;
>> unsigned int idle, idletimer;
>> .....
>> };
>>
>> while in linux/include/net/ax25.h timers are unsigned long
>> according to kernel 2.6 timers.
>>
>> typedef struct ax25_cb {
>> .....
>> struct timer_list t1timer, t2timer, t3timer, idletimer;
>> unsigned long t1, t2, t3, idle, rtt;
>> ....
>>
>> Although ax25_info_struct is not much used it is refered at least
>> into libax25 and xfbb BBS application program.
>>
>> It seems thus reasonable to make the change.
>>
>> Signed-off-by: Bernard Pidoux <f6bvp(AT)amsat.org>
>>
>
> Unfortunately this datastructure is exported to userspace,
> and therefore we cannot change the structure layout without
> breaking userspace.
>
> We cannot, as a result, make this change.
>
> The only way to fix this is to make a new fixed structure, and add new
> ax25 calls that accept this new structure.
> --
--
******************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN EFFORT TO
PROMOTE FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING
SYSTEMS AND PACKET RADIO
Courtesy Tony VK7AX VK7AX(AT)VK7AX.#ULV.TAS.AUS.OC
******************************************************************
Read previous mail | Read next mail
| |
