| |
VK7AX > LINHAM 18.06.08 01:26l 50 Lines 1412 Bytes #999 (0) @ WW
BID : VK7AX-1806XL
Read: GUEST
Subj: [PATCH]: Fix open-coded sock_orphan() in x25.
Path: IZ3LSV<IK2XDE<DB0RES<DK0WUE<ON0BEL<VK7AX
Sent: 080617/2327Z @:VK7AX.#ULV.TAS.AUS.OC #:47478 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: David Miller <davem(AT)davemloft.net>
Date: Tue, 17 Jun 2008 03:06:46 -0700 (PDT)
To: eis(AT)baty.hanse.de
CC: linux-x25(AT)vger.kernel.org, netdev(AT)vger.kernel.org,
ralf(AT)linux-mips.org, linux-hams(AT)vger.kernel.org
This is similar to the AF_ECONET patch I just posted.
Applied and pushed to net-next-2.6
x25: Use sock_orphan() instead of open-coded (and buggy) variant.
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.
Signed-off-by: David S. Miller <davem(AT)davemloft.net>
---
net/x25/af_x25.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index bcb091f..7b1c6ef 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
(AT)(AT) -612,8 +612,7 (AT)(AT) static int x25_release(struct socket *sock)
break;
}
- sock->sk = NULL;
- sk->sk_socket = NULL; /* Not used, but we should do this */
+ sock_orphan(sk);
out:
return 0;
}
-- 1.5.5.1.308.g1fbb5 --
*******************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN EFFORT TO
PROMOTE FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING
SYSTEMS AND PACKET RADIO
Courtesy Tony VK7AX VK7AX(AT)VK7AX.#ULV.TAS.AUS.OC
*******************************************************************
Read previous mail | Read next mail
| |
