| |
VK7AX > LINHAM 18.06.08 01:26l 76 Lines 2289 Bytes #999 (0) @ WW
BID : VK7AX-1806LA
Read: GUEST
Subj: [PATCH]: Consolidate rose socket grafting.
Path: IZ3LSV<IK2XDE<DB0RES<DK0WUE<7M3TJZ<ON0BEL<VK7AX
Sent: 080617/2327Z @:VK7AX.#ULV.TAS.AUS.OC #:47476 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: David Miller <davem(AT)davemloft.net>
Date: Tue, 17 Jun 2008 02:42:24 -0700 (PDT)
To: netdev(AT)vger.kernel.org
CC: ralf(AT)linux-mips.org, linux-hams(AT)vger.kernel.org
Finally, this is the rose version of the ax25 socket
grafting change.
Someone sufficiently motivated might want to make a nice
radio protocol stack common layer. As several have noticed
and noted in the past, rose ax25 and netrom all have
an enormous amount of duplicated code.
Applied and pushed to net-next-2.6
rose: Use sock_graft() and remove bogus sk_socket and sk_sleep init.
This is the rose variant of changeset
9375cb8a1232d2a15fe34bec4d3474872e02faec
("ax25: Use sock_graft() and remove bogus sk_socket and sk_sleep init.")
Signed-off-by: David S. Miller <davem(AT)davemloft.net>
---
net/rose/af_rose.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index 1ebf652..af86bcb 100644
--- a/net/rose/af_rose.c
+++ b/net/rose/af_rose.c
(AT)(AT) -566,13 +566,11 (AT)(AT) static struct sock *rose_make_new(struct sock *osk)
#endif
sk->sk_type = osk->sk_type;
- sk->sk_socket = osk->sk_socket;
sk->sk_priority = osk->sk_priority;
sk->sk_protocol = osk->sk_protocol;
sk->sk_rcvbuf = osk->sk_rcvbuf;
sk->sk_sndbuf = osk->sk_sndbuf;
sk->sk_state = TCP_ESTABLISHED;
- sk->sk_sleep = osk->sk_sleep;
sock_copy_flags(sk, osk);
init_timer(&rose->timer);
(AT)(AT) -924,14 +922,12 (AT)(AT) static int rose_accept(struct socket *sock, struct socket *newsock, int flags)
goto out_release;
newsk = skb->sk;
- newsk->sk_socket = newsock;
- newsk->sk_sleep = &newsock->wait;
+ sock_graft(newsk, newsock);
/* Now attach up the new socket */
skb->sk = NULL;
kfree_skb(skb);
sk->sk_ack_backlog--;
- newsock->sk = newsk;
out_release:
release_sock(sk);
-- 1.5.5.1.308.g1fbb5 --
*******************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN EFFORT TO
PROMOTE FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING
SYSTEMS AND PACKET RADIO
Courtesy Tony VK7AX VK7AX(AT)VK7AX.#ULV.TAS.AUS.OC
*******************************************************************
Read previous mail | Read next mail
| |
