| |
VK7AX > LINHAM 14.05.08 00:38l 63 Lines 1683 Bytes #999 (0) @ WW
BID : VK7AX-1405PA
Read: GUEST
Subj: [PATCH 5/6] drivers/net/hamradio: remove null pointer derefe
Path: IZ3LSV<IK2XDE<I0TVL<VK2TGB<VK7AX
Sent: 080513/2240Z @:VK7AX.#ULV.TAS.AUS.OC #:45449 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: Julia Lawall <julia@diku.dk>
Date: Mon, 12 May 2008 15:38:49 +0200 (CEST)
To: jpr@f6fbb.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
From: Julia Lawall <julia@diku.dk>
If dev is NULL, it is not possible to access its name field. So I have
simply modified the error message to drop the printing of the name field.
This problem was found using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@
* if (E == NULL)
{
... when != if (E == NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
--- a/drivers/net/hamradio/yam.c 2008-04-07 13:50:26.000000000 +0200
+++ b/drivers/net/hamradio/yam.c 2008-05-12 09:52:58.000000000 +0200
@@ -1123,8 +1123,7 @@ static int __init yam_init_driver(void)
dev = alloc_netdev(sizeof(struct yam_port), name,
yam_setup);
if (!dev) {
- printk(KERN_ERR "yam: cannot allocate net device %s\n",
- dev->name);
+ printk(KERN_ERR "yam: cannot allocate net device\n");
err = -ENOMEM;
goto error;
}
--
**************************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN ATTEMPT TO PROMOTE
FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING SYSTEMS & PACKET RADIO
Courtesy Tony VK7AX VK7AX@VK7AX.#ULV.TAS.AUS.OC
**************************************************************************
Read previous mail | Read next mail
| |
