| |
VK7AX > LINHAM 01.05.08 12:58l 60 Lines 1939 Bytes #999 (0) @ WW
BID : VK7AX-0105LA
Read: GUEST
Subj: [PATCH] Wrong list_lock argument in rose_node seqops
Path: IZ3LSV<IQ0LT<IK2XDE<DB0RES<DK0WUE<7M3TJZ<ZL2BAU<VK7AX
Sent: 080501/1151Z @:VK7AX.#ULV.TAS.AUS.OC #:44502 [Ulverstone] FBB7.00g $:VK7A
From: VK7AX@VK7AX.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: Bernard Pidoux <bpidoux@free.fr>
Date: Wed, 30 Apr 2008 22:08:56 +0200
To: David Miller <davem@davemloft.net>
CC: Ralf Baechle DL5RB <ralf@linux-mips.org>, Linux Netdev List <netdev@vger.kernel.org>, "linux-hams" <linux-hams@vger.kernel.org>
In rose_node_start() as well as in rose_node_stop()
__acquires() and spin_lock_bh() were wrongly passing
rose_neigh_list_lock instead of rose_node_list_lock arguments.
Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
---
net/rose/rose_route.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index 5053a53..bd59387 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -1066,12 +1066,12 @@ out:
#ifdef CONFIG_PROC_FS
static void *rose_node_start(struct seq_file *seq, loff_t *pos)
- __acquires(rose_neigh_list_lock)
+ __acquires(rose_node_list_lock)
{
struct rose_node *rose_node;
int i = 1;
- spin_lock_bh(&rose_neigh_list_lock);
+ spin_lock_bh(&rose_node_list_lock);
if (*pos == 0)
return SEQ_START_TOKEN;
@@ -1090,9 +1090,9 @@ static void *rose_node_next(struct seq_file *seq, void *v, loff_t *pos)
}
static void rose_node_stop(struct seq_file *seq, void *v)
- __releases(rose_neigh_list_lock)
+ __releases(rose_node_list_lock)
{
- spin_unlock_bh(&rose_neigh_list_lock);
+ spin_unlock_bh(&rose_node_list_lock);
}
static int rose_node_show(struct seq_file *seq, void *v)
-- 1.5.5 --
--------------------------------------------------------------------------
**************************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN ATTEMPT TO PROMOTE
FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING SYSTEMS & PACKET RADIO
Courtesy Tony VK7AX VK7AX@VK7AX.#ULV.TAS.AUS.OC
**************************************************************************
Read previous mail | Read next mail
| |
