| |
VK7AX > LINHAM 22.04.08 01:57l 53 Lines 1833 Bytes #999 (0) @ WW
BID : VK7AX-2204HD
Read: GUEST
Subj: Re: [PATCH] soft lockup rose_node_list_lock
Path: IZ3LSV<IQ0LT<IK2XDE<ON4HU<SR1BSZ<WA7V<VK7NW
Sent: 080422/0059Z @:VK7NW.#ULV.TAS.AUS.OC #:43799 [NWTARIG] FBB7.00g $:VK7AX-2
From: VK7AX@VK7NW.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: David Miller <davem@davemloft.net>
Date: Sun, 20 Apr 2008 15:59:24 -0700 (PDT)
To: pidoux@ccr.jussieu.fr
CC: ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org
From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
Date: Sun, 20 Apr 2008 19:09:23 +0200
> > Since rose_route_frame() does not use rose_node_list we can safely
> > remove rose_node_list_lock spin lock here and let it be free for
> > rose_get_neigh().
> >
> > Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
Indeed, I went over this code several times and I can't
see any reason for rose_route_frame() to take the node
list lock.
Patch applied, thanks Bernard. But one thing...
> > diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
> > index fb9359f..5053a53 100644
> > --- a/net/rose/rose_route.c
> > +++ b/net/rose/rose_route.c
> > @@ -857,7 +857,6 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)
> > src_addr = (rose_address *)(skb->data + 9);
> > dest_addr = (rose_address *)(skb->data + 4);
> >
> > - spin_lock_bh(&rose_node_list_lock);
> > spin_lock_bh(&rose_neigh_list_lock);
> > spin_lock_bh(&rose_route_list_lock);
> >
Could you please fix your email client so it doesn't corrupt
patches like this? I've had to apply all of your patches by
hand because the tabs have been converted into spaces. Use
MIME attachments if you have to.
Thanks again.
--
**************************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN ATTEMPT TO PROMOTE
FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING SYSTEMS & PACKET RADIO
Courtesy Tony VK7AX VK7AX@VK7NW.#ULV.TAS.AUS.OC
**************************************************************************
Read previous mail | Read next mail
| |
