| |
VK7AX > LINHAM 22.04.08 02:57l 49 Lines 1634 Bytes #999 (0) @ WW
BID : VK7AX-2204ZU
Read: GUEST
Subj: [PATCH] Remove unneeded and deprecated cli()/sti() calls.
Path: IZ3LSV<IQ0LT<IK2XDE<DB0RES<ON0AR<ZL2BAU<VK7NW
Sent: 080422/0053Z @:VK7NW.#ULV.TAS.AUS.OC #:43797 [NWTARIG] FBB7.00g $:VK7AX-2
From: VK7AX@VK7NW.#ULV.TAS.AUS.OC
To : LINHAM@WW
From: Mark Asselstine <mark.asselstine@windriver.com>
Date: Mon, 21 Apr 2008 15:49:10 -0400
To: kernel-janitors@vger.kernel.org
CC: netdev@vger.kernel.org, asselsm@gmail.com, klaus.kudielka@ieee.org, linux-hams@vger.kernel.org, Mark Asselstine <mark.asselstine@windriver.com>
These cli()/sti() calls are made in start_timer() and are therefor
redundant since the register_lock is now used to protect register
io from within scc_isr() and write_scc() (where all calls to
start_timer() originate).
Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---
drivers/net/hamradio/dmascc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c
index e04bf99..0b94833 100644
--- a/drivers/net/hamradio/dmascc.c
+++ b/drivers/net/hamradio/dmascc.c
@@ -1083,15 +1083,12 @@ static void start_timer(struct scc_priv *priv, int t, int r15)
if (t == 0) {
tm_isr(priv);
} else if (t > 0) {
- save_flags(flags);
- cli();
outb(t & 0xFF, priv->tmr_cnt);
outb((t >> 8) & 0xFF, priv->tmr_cnt);
if (priv->type != TYPE_TWIN) {
write_scc(priv, R15, r15 | CTSIE);
priv->rr0 |= CTS;
}
- restore_flags(flags);
}
}
--
**************************************************************************
ABOVE IS A CROSS POST TO THE PACKET RADIO NETWORK IN AN ATTEMPT TO PROMOTE
FURTHER INTEREST IN HAM SOFTWARE USING LINUX OPERATING SYSTEMS & PACKET RADIO
Courtesy Tony VK7AX VK7AX@VK7NW.#ULV.TAS.AUS.OC
**************************************************************************
Read previous mail | Read next mail
| |
